On Thu, Mar 18, 2010 at 9:53 AM, Kumar Gala <ga...@kernel.crashing.org> wrote: > + /* The multiple setting ppc_md.setup_msi_irqs will not harm things */ > + if (!ppc_md.setup_msi_irqs) { > + ppc_md.setup_msi_irqs = fsl_setup_msi_irqs; > + ppc_md.teardown_msi_irqs = fsl_teardown_msi_irqs; > + ppc_md.msi_check_device = fsl_msi_check_device; > + } else if (ppc_md.setup_msi_irqs != fsl_setup_msi_irqs) { > + dev_err(&dev->dev, "Different MSI driver already > installed!\n"); > + err = -EBUSY; /* or some other error code */
The comment is inappropriate. I put it there as a reminder that maybe EBUSY is not the best choice. But if it is, then the comment should be removed. -- Timur Tabi Linux kernel developer at Freescale _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev