On Thu, Jun 17, 2010 at 5:57 PM, Benjamin Herrenschmidt <b...@kernel.crashing.org> wrote: > On Thu, 2010-06-17 at 17:11 -0600, Grant Likely wrote: >> On Thu, Jun 10, 2010 at 7:17 PM, Benjamin Herrenschmidt >> <b...@kernel.crashing.org> wrote: >> > On Thu, 2010-06-10 at 17:36 -0600, Grant Likely wrote: >> >> >> >> Okay. I had been trying to avoid #ifdefs in the common code, but >> >> you're probably right. I'll rework. >> > >> > Not even ifdef's ... just move the quirk map there. You can always >> > #define the quirk variable to 0 on archs that have no quirks, to >> > make it compile away if you believe it represents bloat, but they >> > are simple well localized things so I doubt it matters. >> >> They're pretty small, but powermac32 is the only code that actually >> uses the quirk facility. Everything else parses sanely it would >> appear. I'd rather have them localized to the powermac code and >> eliminate the quirks from the common code. > > Maybe, but the way you end up gutting out some internal functions of the > parser so they can be overriden by the arch is just plain gross :-)
Heh, I won't dispute that. Give me a day or so. If I can't come up with anything better, then I'll just move it all over. g. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
