Hello, On Thu, Jul 22, 2010 at 7:38 PM, Kumar Gala <ga...@kernel.crashing.org> wrote: > > On Jul 21, 2010, at 7:03 PM, Dmitry Eremin-Solenikov wrote: > >> Currently (as mpc8540-pci) devices are not created on of_platform bus, >> mpc85xx_edac can't probe to them. Follow the change to dts trees to bind >> not to the main mpc8540-pci node but to special mpc85xx-pci-error nodes, >> present on soc bus. >> >> Signed-off-by: Dmitry Eremin-Solenikov <dbarysh...@gmail.com> >> --- >> drivers/edac/mpc85xx_edac.c | 18 +++++++++--------- >> 1 files changed, 9 insertions(+), 9 deletions(-) > > Nak. > > We already have a node in the dts for the PCI controller. Lets update the > platform code to add the pci controller to the of_platform_bus_probe list.
I've had that idea. However it's really look strange to me to call of_platform_bus_probe() on the bus node, for which we (IMO) explicitly won't like for child devices (PCI devices) to be added to of_platform bus. Would it be suitable to just call of_platform_device_create for it (Or do i miss someth<ing)? BTW: While I'm at it, should I change all mpc8540-pci/-pcix device names to include respective SoC name? -- With best wishes Dmitry _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
