> diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c > index 731150d..c266c1e 100644 > --- a/drivers/usb/gadget/amd5536udc.c > +++ b/drivers/usb/gadget/amd5536udc.c > @@ -1954,13 +1954,14 @@ static int setup_ep0(struct udc *dev) > } > > /* Called by gadget driver to register itself */ > -int usb_gadget_register_driver(struct usb_gadget_driver *driver) > +int usb_gadget_probe_driver(struct usb_gadget_driver *driver, > + int (*bind)(struct usb_gadget *)) > { > struct udc *dev = udc; > int retval; > u32 tmp; > > - if (!driver || !driver->bind || !driver->setup > + if (!driver || bind || !driver->setup
I have the impression that this should be !bind rather than bind. That would be like what is done in the patch for drivers/usb/gadget/fsl_udc_core.c below > diff --git a/drivers/usb/gadget/fsl_udc_core.c > b/drivers/usb/gadget/fsl_udc_core.c > index 08a9a62..c16b402 100644 > --- a/drivers/usb/gadget/fsl_udc_core.c > +++ b/drivers/usb/gadget/fsl_udc_core.c > @@ -1765,7 +1765,8 @@ static irqreturn_t fsl_udc_irq(int irq, void *_udc) > * Hook to gadget drivers > * Called by initialization code of gadget drivers > *----------------------------------------------------------------*/ > -int usb_gadget_register_driver(struct usb_gadget_driver *driver) > +int usb_gadget_probe_driver(struct usb_gadget_driver *driver, > + int (*bind)(struct usb_gadget *)) > { > int retval = -ENODEV; > unsigned long flags = 0; > @@ -1775,8 +1776,7 @@ int usb_gadget_register_driver(struct usb_gadget_driver > *driver) > > if (!driver || (driver->speed != USB_SPEED_FULL > && driver->speed != USB_SPEED_HIGH) > - || !driver->bind || !driver->disconnect > - || !driver->setup) > + || !bind || !driver->disconnect || !driver->setup) > return -EINVAL; Here !driver->bind is converted to !bind. julia _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev