> -----Original Message----- > From: > linuxppc-dev-bounces+tiejun.chen=windriver....@lists.ozlabs.or > g > [mailto:linuxppc-dev-bounces+tiejun.chen=windriver....@lists.o > zlabs.org] On Behalf Of Benjamin Herrenschmidt > Sent: Friday, September 24, 2010 5:59 AM > To: Scott Wood > Cc: Gortmaker, Paul; linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH] powerpc: Fix invalid page flags in > create TLB CAM pathfor PTE_64BIT > > On Thu, 2010-09-23 at 15:33 -0500, Scott Wood wrote: > > I don't see a generic accessor that can test PTE flags for > user access > > -- in the absence of one, I guess we need an ifdef here. > Or at least > > put in a comment so anyone who adds a userspace use knows > they need to > > fix it. > > We could make up one in powerpc arch at least > > #define pte_user(val) ((val & _PAGE_USER) == _PAGE_USER) >
Looks good. Ben and Scott, But for the patched issue we're discussing we have to do #ifdef that as my original modification. Right? Or do you have other suggestion? Then I can improve that as v2. Thanks Tiejun > would do > > Cheers, > Ben. > > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
