> > +   setbits8(&bcsr[7], BCSR_USB_EN);
> > +   udelay(100000);
> > +
> > +   clrbits8(&bcsr[7], BCSR_USB_EN);
> > +   udelay(100000);
> 
> Thats a total bootup delay of 200ms. Is this really needed?

In addition, so large delays should use msleep() if possible (depends
how early we are here).

Cheers,
Ben,

> And I suggest to add a few comments to the code explaining why exactly you 
> are 
> setting/clearing the bits in the BCSR and the GPIO registers.

Seconded,

Cheers,
Ben.


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to