On Tue, Feb 01, 2011 at 12:48:45PM -0600, Dave Kleikamp wrote:
>+static ibm4xx_memstart;
>+
> static void iss_4xx_fixups(void)
> {
>-      ibm4xx_sdram_fixup_memsize();
>+      void *memory;
>+      u32 reg[3];
>+
>+      memory = finddevice("/memory");
>+      if (!memory)
>+              fatal("Can't find memory node\n");
>+      getprop(memory, "reg", reg, sizeof(reg));
>+      if (reg[1] || reg[2])

Wouldn't this test allow for a faulty device tree that specified a 0
size (0x0 in reg[2])?  Maybe just check reg[2] for non-zero instead?

josh
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to