On Wed, 2011-02-16 at 16:38 +1100, Alexey Kardashevskiy wrote: > step1: http://patchwork.ozlabs.org/patch/71489/ > step2: http://patchwork.ozlabs.org/patch/81423/ > > In step2 I defined sysfs node as: > > static SYSDEV_ATTR(dscr_default, 0600, show_dscr_default, > store_dscr_default); > > and it caused problems with rhel6. > Now it is: > > static SYSDEV_CLASS_ATTR(dscr_default, 0600, show_dscr_default, > store_dscr_default); > > It works now on both 2.6.32 and 2.6.36 but is that correct?
Ok, please resend with a proper changeset comment, something like that would do: << The DSCR (aka Data Stream Control Register) is supported on some server PowerPC chips and allow some control over the prefetch of data streams. This patch allows the value to specified per thread by emulating the corresponding mfspr and mtspr instructions. Children of such threads inherit the value. Other threads use a default value that can be specified in sysfs. >> And include your Signed-off-by: line. BTW. I suppose it's an expected behaviour that thread created with a given default value will keep that value even when the default is later changed right ? And their descendents will use the same default as the original thread, not the new default, at least that's how I read your code :-) Maybe that should be documented somewhere... Cheers, Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
