On Thu, 19 May 2011 07:22:25 -0700
Greg KH <g...@kroah.com> wrote:
> On Thu, May 19, 2011 at 08:54:31AM -0500, Timur Tabi wrote:
> > +/*
> > + * The udbg subsystem calls this function to display a single character.
> > + * We convert CR to a CR/LF.
> > + */
> > +static void ehv_bc_udbg_putc(char c)
> > +{
> > + if (c == '\n')
> > + byte_channel_spin_send('\r');
> > +
> > + byte_channel_spin_send(c);
> > +}
>
> Why do this conversion in the driver? Shouldn't that be something that
> userspace worries about?
udbg is a bit before the land of userspace so it needs to do whatever
adaption the firmware/happyvisor interface wants.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
