On Wed, 1 Jun 2011 18:55:35 +0400 Dmitry Eremin-Solenikov <dbarysh...@gmail.com> wrote:
> On 6/1/11, Anton Vorontsov <avoront...@mvista.com> wrote: > > On Wed, Jun 01, 2011 at 04:28:11PM +0400, Dmitry Eremin-Solenikov wrote: > > [...] > > Also, why not add this call to the fsl_add_bridge(), so you > > won't need to touch board files at all. > > Because fsl_add_bridge is called too early, so allocation > of platform device fails. That doesn't seem like a good reason for putting more stuff in board files that isn't board-specific. Why not just make fsl_add_pci_err() an initcall? It already only works when a compatible device tree node is found. Is there any case where a board would not want this PCI code to be used, even if the device tree node is present? If so, fsl_add_bridge could set a flag that fsl_add_pci_err() could check -- but I doubt it's needed. -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
