On Tue, 23 Aug 2011 13:53:46 -0700 Geoff Levand <ge...@infradead.org> wrote:
[...]
> >
> > + if (!map.r1.size) {
> > + DBG("%s:%d: no region 1, not adding memory\n",
> > + __func__, __LINE__);
> > + } else {
>
> Remove brackets around a single line conditional.
>
> > + DBG("%s:%d: adding memory: start %llxh, size %llxh\n",
> > + __func__, __LINE__, map.rm.size, map.r1.size);
> > +
> > + memblock_add(map.rm.size, map.r1.size);
> > + memblock_analyze();
> > + }
> > +
In Documentation/CodingStyle I read that if [only] one branch is a
single statement then the parenthesis are OK (and even recommended) for
both branches, I guess this is for style consistency. See Chapter 3,
around line 169 on my copy. I guess the wording on that paragraph can
be made more explicit, I'll try to fix that up.
Regards,
Antonio
--
Antonio Ospite
http://ao2.it
PGP public key ID: 0x4553B001
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
pgpC8bdEgALbX.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
