On Thu, Aug 25, 2011 at 01:02:01PM -0500, Timur Tabi wrote: > Greg KH wrote: > > tested doesn't mean that it shouldn't still build properly for other > > platforms, right? > > The problem is the dependency on MSR_GS, which is defined only for Book-E > PowerPC chips, not all PowerPC. > > So I gave it some more thought, and technically ePAPR extends beyond Book-E, > so > it's wrong for the driver to depend on anything specific to Book-E. I've > removed the code that breaks: > > /* Check if we're running as a guest of a hypervisor */ > if (!(mfmsr() & MSR_GS)) > return;
But don't you really want this type of check at runtime? What happens if you load this driver on a machine that is not a guest? Will things break? Shouldn't you still refuse to load somehow? thanks, greg k-h _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
