On 08/30/11 11:51, Benjamin Herrenschmidt wrote:
On Tue, 2011-08-30 at 16:19 +1000, Benjamin Herrenschmidt wrote:
On Tue, 2011-08-30 at 11:47 +0530, Suzuki Poulose wrote:


The flash operation is performed in the reboot path at the very end.
So, even if we restart the event scan, the thread may not be able to
process
the events. Hence we thought we would leave it stopped.

Again, we do not have much expertise in deciding which is the best
thing to do.
We could resume the event scan, if you think that is needed.

Thanks for the review.

No that's ok, I'll merge the patch as-is then.

Actually, please dbl check you get the dependencies right. The event
scan stuff is only compiled if CONFIG_PPC_RTAS_DAEMON is set, but the
rtas flash code depends on a different config option that can be set
independently.

So at the very least you need an ifdef to guard the cross-call

Thanks for catching this ! Will address this in the next version.

Thanks
Suzuki
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to