> What is this __iowrite64_copy... oh I see > > Nice, somebody _AGAIN_ added a bunch of "generic" IO > accessors that are utterly wrong on all archs except > x86 (ok, -almost-). > There isn't a single bloody memory barrier in there !
Actually memory barriers shouldn't really be added to any of these 'accessor' functions. (Or, at least, ones without barriers should be provided.) The driver may want to to a series of writes, then a single barrier, before a final write of a command (etc). in_le32() from io.h is specially horrid! David _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev