On Wed, Oct 12, 2011 at 18:07, Kumar Gala <ga...@kernel.crashing.org> wrote: > On Oct 12, 2011, at 10:32 AM, Hans J. Koch wrote: >> On Wed, Oct 12, 2011 at 09:35:45AM -0500, Kumar Gala wrote: >>> From: Kai Jiang <kai.ji...@freescale.com> >>> >>> To support >32-bit physical addresses for UIO_MEM_PHYS type we need to >>> extend the width of 'addr' in struct uio_mem. Numerous platforms like >>> embedded PPC, ARM, and X86 have support for systems with larger physical >>> address than logical. >>> >>> Since 'addr' may contain a physical, logical, or virtual address the >>> easiest solution is to just change the type to 'unsigned long long' >>> regardless of which type is utilized. >> >> No. There's phys_addr_t for that purpose, defined in include/linux/types.h. >> Please use that. > > Do we believe phys_addr_t is always greater than or equal to size need for > logical & virtual addresses?
Yes: #ifdef CONFIG_PHYS_ADDR_T_64BIT typedef u64 phys_addr_t; #else typedef u32 phys_addr_t; #endif config PHYS_ADDR_T_64BIT def_bool 64BIT || ARCH_PHYS_ADDR_T_64BIT Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev