On 10/12/2011 09:15 AM, Dave Hansen wrote: > On Tue, 2011-10-11 at 18:24 +0530, Suzuki Poulose wrote: >> On 10/10/11 23:30, Scott Wood wrote: >>> On 10/10/2011 04:56 AM, Suzuki K. Poulose wrote: >>>> #if defined(CONFIG_RELOCATABLE)&& defined(CONFIG_44x) >>>> #define __va(x) ((void *)(unsigned long)((phys_addr_t)(x) - PHYSICAL_START >>>> + (KERNELBASE + RELOC_OFFSET))) >>>> #define __pa(x) ((unsigned long)(x) + PHYSICAL_START - (KERNELBASE + >>>> RELOC_OFFSET)) >>>> #endif >>> >>> Why is this 44x-specific? >> >> As of now, we compile with relocations only for the 44x. We could make this >> generic once the approach is accepted by everyone and implemented on the >> other >> platforms. > > This is not the place to enforce that kind of thing. If > CONFIG_RELOCATABLE is only supported on one platform, then do: > > config RELOCATABLE > depends on 44x > > and take the 44x reference out of the #ifdef.
...but please first rename the existing, different CONFIG_RELOCATABLE behavior that is currently supported on e500. -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
