On Fri, Apr 27, 2012 at 10:11:35AM -0400, Joe Perches wrote: > > > -extern struct mem_ctl_info *edac_mc_alloc(unsigned sz_pvt, unsigned > > > nr_csrows, > > > - unsigned nr_chans, int edac_index); > > > +struct mem_ctl_info *edac_mc_alloc(unsigned sz_pvt, unsigned nr_csrows, > > > + unsigned nr_chans, int edac_index); > > > > Why not "extern"? > > Using extern function prototypes in .h files > isn't generally necessary nor is extern the > more common kernel style.
Searching for it, there's this discussion, for example: http://gcc.gnu.org/ml/gcc/2009-04/msg00812.html Maybe we should put a small note in Documentation/CodingStyle what the kernel preference is and hold people to it. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
