Dear Rupjyoti Sarmah, In message <[email protected]> you wrote: > > Add Synopsys Design Ware core register definitions.
Olof Johansson <[email protected]> has commented v15 of this patch as follows: > No, just start over from scratch. Just leave the crap driver behind, > use it for reference but write the new one. > > It's obvious given that you are already at iteration v15 and it's > still looking this bad that this is not realistic to get reviewed and > accepted as-is. I don't think staging is a good target either -- what > the driver really needs is _functional_ cut-down to only cover the use > cases that your product uses, and staging cleanups are mostly around > style and refactoring, not changing, fixing or removing functionality. > ... > I don't think you understood what I meant. Try building an ARM config > with this driver enabled, for example, and you'll see that it breaks > the build. See http://thread.gmane.org/gmane.linux.usb.general/53348/focus=53913 for the full context and other important comments. It seems most of these requests have been ignored so far. I would also like to point out that the same Synopsys USB controller is used in a number of other SoCs (especially ARM chips), and supported by other drivers, some of these even in mainline. See http://thread.gmane.org/gmane.linux.usb.general/61714/focus=62139 for a related thread. Instead of trying to add a completely new driver to mainline (and one which has been repeatedly been rejected), I vote for focussing on the existing driver code that is already in mainline, and testing and improving this so we can use a single implementation of this driver code for all SoCs that use the same IP block. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] panic: kernel trap (ignored) _______________________________________________ Linuxppc-dev mailing list [email protected] https://lists.ozlabs.org/listinfo/linuxppc-dev
