> -----Original Message----- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Thursday, August 02, 2012 8:24 PM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472 > Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie > initialization code > > > On Aug 2, 2012, at 6:42 AM, Jia Hongtao wrote: > > > We unified the Freescale pci/pcie initialization by changing the > fsl_pci > > to a platform driver. In previous PCI code architecture the > initialization > > routine is called at board_setup_arch stage. Now the initialization is > done > > in probe function which is architectural better. Also It's convenient > for > > adding PM support for PCI controller in later patch. > > > > Now we registered pci controllers as platform devices. So we combine > two > > initialization code as one platform driver. > > > > Signed-off-by: Jia Hongtao <b38...@freescale.com> > > Signed-off-by: Li Yang <le...@freescale.com> > > Signed-off-by: Chunhe Lan <chunhe....@freescale.com> > > --- > > arch/powerpc/platforms/85xx/mpc85xx_ds.c | 32 ++-------- > > arch/powerpc/sysdev/fsl_pci.c | 102 ++++++++++++++++++----- > ------ > > arch/powerpc/sysdev/fsl_pci.h | 6 +- > > drivers/edac/mpc85xx_edac.c | 43 ++++--------- > > 4 files changed, 83 insertions(+), 100 deletions(-) > > You need to convert all boards to use fsl_pci_init before this patch. > Otherwise we'll end up with PCI getting initialized twice on boards. > > - k
If we covert all boards with platform driver in this patch PCI will be initialized only once without converting all boards to use fsl_pci_init first. If we convert all boards to use fsl_pci_init before this patch and convert them to use platform driver again after this patch. Then between this patch and next pci will be initialized twice too. So I think convert all boards in this patch is the key not convert all boards to use fsl_pci_init first before this patch. -Hongtao. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
