On Tue, Aug 21, 2012 at 02:22:28PM -0400, Paul Gortmaker wrote: > From: Joe MacDonald <joe.macdon...@windriver.com> > > sys_subpage_prot() takes an unsigned long for 'addr' then does some stuff > with it and the result is stored in a signed int, i, which is eventually > used as the size parameter in a copy_from_user call. Update 'i' to be an > unsigned long as well and since 'nw' is used in a size_t context which, > depending on whether this is 32- or 64-bit may be unsigned int or unsigned > long, switch that to a size_t and always be right. > > Finally, since we're in the neighbourhood, make the same changes to > subpage_prot_clear(). > > Cc: Paul Mackerras <pau...@samba.org> > Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> > Signed-off-by: Joe MacDonald <joe.macdon...@windriver.com> > Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com>
This change won't hurt; in fact it won't make any difference since (a) this code is only ever used on 64-bit and (b) i and nw are restricted to the range 0 .. PTRS_PER_PTE - 1, but I agree the code is slightly cleaner this way. Acked-by: Paul Mackerras <pau...@samba.org> _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
