Hi Kumar, Do you or Ben has any comment on this? Please let me know.
Thanks. ________________________________________ From: Jia Hongtao-B38951 Sent: Friday, August 31, 2012 10:25 AM To: Kumar Gala Cc: linuxppc-dev@lists.ozlabs.org; Li Yang-R58472; Wood Scott-B07421 Subject: RE: [PATCH V10] powerpc/fsl-pci: Unify pci/pcie initialization code > -----Original Message----- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Friday, August 31, 2012 12:54 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; Li Yang-R58472; Wood Scott-B07421 > Subject: Re: [PATCH V10] powerpc/fsl-pci: Unify pci/pcie initialization > code > > > On Aug 28, 2012, at 2:44 AM, Jia Hongtao wrote: > > > We unified the Freescale pci/pcie initialization by changing the > > fsl_pci to a platform driver. In previous PCI code architecture the > > initialization routine is called at board_setup_arch stage. Now the > > initialization is done in probe function which is architectural > > better. Also It's convenient for adding PM support for PCI controller > in later patch. > > > > Now we registered pci controllers as platform devices. So we combine > > two initialization code as one platform driver. > > > > Signed-off-by: Jia Hongtao <b38...@freescale.com> > > Signed-off-by: Li Yang <le...@freescale.com> > > Signed-off-by: Chunhe Lan <chunhe....@freescale.com> > > --- > > Changes for V10: > > * Just update comments for mpc85xx_cds_pci_assign_primary > > What do we have to say w/regards to Ben's comment about breaking of > pci_fixup_final by moving to a platform driver? > > - k If Ben mean the fixup order I have already gave some explanations as follow: I have already done some investigations and the sequence of fixup (including early, header, final) will not be changed in platform driver. We register and init PCI controllers as platform devices at arch_initcall stage and PCI scanning (pcibios_init) is at subsys_initcall stage in which early and header fixup will be done in right sequence. The final fixup will be start at rootfs_initcall stage which is later than early and header fixup. - Hongtao. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
