On 10/09/2012 08:56:53 AM, Wang Dongsheng-B40534 wrote:
> > > > I'm pretty sure /proc/ is NOT where we want this exposed.
> > >
> > > Should probably go under the sysfs directory of the mpic
device. Or
> > > better, make a generic interface for timer-based suspend wakeup
(if
> > there
> > > isn't one already). This current approach sits in an unpleasant
> middle
> > > ground between generic and device-specific.
> > >
> > /sys/power/wakeup_timer_seconds how about this?
> > I think it is a freescale generic interface, this interface
control by
> > FSL_SOC && SUSPEND.
> There's no such thing as a "Freescale generic interface". Linux
APIs
> are not organized by hardware vendor. Either make a truly generic
> interface, reuse an existing one, or do something that is attached
to
> the specific driver.
Thanks, I think i can change mpic timer registration, i will use
platform_driver_register.
I will merge "mpic timer" and "timer wakeup". In "mpic timer" the
wakeup function
controls by SUSPEND. The sys path is
"/sys/devices/soc8572.4/ffe41100.timer/wakeup_seconds".
do you have any suggestions for this? or have a better idea about the
sys path?
I'm not sure what you mean by the merging, but the path looks OK (I'd
prefer a dash rather than underscore, but I'm not sure what the usual
practice is in sysfs).
That said, this seems like something that could use a truly generic
interface.
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
