On Thu, Feb 21, 2013 at 10:17:10PM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" <aneesh.ku...@linux.vnet.ibm.com> > > USE PTRS_PER_PTE to indicate the size of pte page. > > Signed-off-by: Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com> > powerpc: Don't hard code the size of pte page > > USE PTRS_PER_PTE to indicate the size of pte page. > > Signed-off-by: Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com>
Description and signoff are duplicated. Description could be more informative, for example - why would we want to do this? > +/* > + * hidx is in the second half of the page table. We use the > + * 8 bytes per each pte entry. The casual reader probably wouldn't know what "hidx" is. The comment needs at least to use a better name than "hidx". Paul. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
