On 07/10/2013 02:39:01 AM, Haijun Zhang wrote:
+/* Get current SOC Version */ +#define GET_SVR() (mfspr(SPRN_SVR))
Unnecessary parens. Why do we need GET_SVR(), versus opencoding it? Note that U-Boot (which this is patterned after) doesn't have GET_SVR(), so code that wants to work on both can't use it anyway.
+#define IS_SVR_REV(svr, maj, min) \ + ((SVR_MAJ(svr) == (maj)) && (SVR_MIN(svr) == (min)))
I don't think IS_SVR_REV is needed. Callers can just do "if (SVR_REV(svr) == 0x30)" or whatever, especially since we're relying on them to do this for greater/less than comparisons.
-Scott _______________________________________________ Linuxppc-dev mailing list [email protected] https://lists.ozlabs.org/listinfo/linuxppc-dev
