On 07/11/2013 07:45:21 AM, Benjamin Herrenschmidt wrote:
On Thu, 2013-07-11 at 20:21 +0800, Kevin Hao wrote:
> Some cores (such as Freescale BookE) don't implement all floating
> point instructions in ISA. But some gcc versions do use these
> instructions. So we would have to enable the math emulation in this
> case. Add this to emulated instructions tracking statistics so that
> the user has a way to know that its toolcahin emit these
unimplemented
> floating point instructions.
That patch is gross, it makes the function even more nasty than it
already is. Besides, CONFIG_PPC_FPU doesn't mean you have a HW FPU,
you need to check the CPU feature bits.
Also the caller already does PPC_WARN_EMULATED, so this patch makes
you call it twice or am I missing something ?
Sorry, that was my fault -- for some reason I didn't see that when I
grepped for PPC_WARN_EMULATED looking for math stuff, and thus
requested it be added. In any case, I don't see why it should be
conditional on having an FPU (and indeed, the warning in the caller
isn't conditional).
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
