"Aneesh Kumar K.V" <aneesh.ku...@linux.vnet.ibm.com> writes:
> From: "Aneesh Kumar K.V" <aneesh.ku...@linux.vnet.ibm.com> > > We should not fallthrough different case statements in hpte_decode. Add > break statement to break out of the switch. The regression is introduced by > dcda287a9b26309ae43a091d0ecde16f8f61b4c0 "powerpc/mm: Simplify hpte_decode" > > Reported-by: Paul Mackerras <pau...@samba.org> > Signed-off-by: Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com> > --- > arch/powerpc/mm/hash_native_64.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/mm/hash_native_64.c > b/arch/powerpc/mm/hash_native_64.c > index 0de15fc..e1f9b82 100644 > --- a/arch/powerpc/mm/hash_native_64.c > +++ b/arch/powerpc/mm/hash_native_64.c > @@ -560,6 +560,7 @@ static void hpte_decode(struct hash_pte *hpte, unsigned > long slot, > seg_off |= vpi << shift; > } > *vpn = vsid << (SID_SHIFT - VPN_SHIFT) | seg_off >> VPN_SHIFT; > + break; > case MMU_SEGSIZE_1T: > /* We only have 40 - 23 bits of seg_off in avpn */ > seg_off = (avpn & 0x1ffff) << 23; > @@ -569,6 +570,7 @@ static void hpte_decode(struct hash_pte *hpte, unsigned > long slot, > seg_off |= vpi << shift; > } > *vpn = vsid << (SID_SHIFT_1T - VPN_SHIFT) | seg_off >> > VPN_SHIFT; > + break; > default: > *vpn = size = 0; > } Any update on this ? -aneesh _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
