On 07/25/2013 04:06 PM, Benjamin Herrenschmidt wrote: > On Thu, 2013-07-25 at 15:59 +0800, Chen Gang wrote: >> >> For my opinion: one fix may like below (assume have removed max_cpus) >> which is more reasonable for code readers. > > So instead of just failing to bring the secondary CPUs, but potentially > still having a working system, you crash during boot.... potentially > before a console is even visible. And this is good how ? >
Hmm... how about the above DBG("...") within this function ? One implementation of BUG_ON() is use printk() and coredump, if it is a critical failure, I suggest to use it (if console is really invisible, I guess still can generate the coredump). Hmm... But do you mean it really can be failed, but it is not a critical failure ? if so we need print the related warning message instead of. Thanks. -- Chen Gang _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev