On 07/30/2013 06:40:29 AM, Chunhe Lan wrote:
P1023RDB Specification:
-----------------------
Memory subsystem:
   512MB DDR3 (Fixed DDR on board)
   64MB NOR flash
   128MB NAND flash

Ethernet:
   eTSEC1: Connected to Atheros AR8035 GETH PHY
   eTSEC2: Connected to Atheros AR8035 GETH PHY

PCIe:
   Three mini-PCIe slots

USB:
   Two USB2.0 Type A ports

I2C:
   AT24C08 8K Board EEPROM (8 bit address)

Signed-off-by: Chunhe Lan <[email protected]>
Cc: Scott Wood <[email protected]>
---
arch/powerpc/boot/dts/p1023rdb.dts | 237 ++++++++++++++++++++++++++ arch/powerpc/configs/85xx/p1023_defconfig | 183 ++++++++++++++++++++ arch/powerpc/configs/85xx/p1023rds_defconfig | 169 ------------------
 arch/powerpc/platforms/85xx/Kconfig          |    4 +-
 arch/powerpc/platforms/85xx/p1023_rds.c      |   24 +++-
 5 files changed, 445 insertions(+), 172 deletions(-)
 create mode 100644 arch/powerpc/boot/dts/p1023rdb.dts
 create mode 100644 arch/powerpc/configs/85xx/p1023_defconfig
 delete mode 100644 arch/powerpc/configs/85xx/p1023rds_defconfig

Please indicate changes from the previous version under the ---


diff --git a/arch/powerpc/boot/dts/p1023rdb.dts b/arch/powerpc/boot/dts/p1023rdb.dts
new file mode 100644
index 0000000..107c676
--- /dev/null
+++ b/arch/powerpc/boot/dts/p1023rdb.dts
@@ -0,0 +1,237 @@
+/*
+ * P1023 RDB Device Tree Source
+ *
+ *    Copyright 2013 Freescale Semiconductor Inc.
+ *
+ * Author: Chunhe Lan <[email protected]>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met: + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution.
+ *     * Neither the name of Freescale Semiconductor nor the
+ * names of its contributors may be used to endorse or promote products + * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the + * GNU General Public License ("GPL") as published by the Free Software + * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY Freescale Semiconductor ``AS IS'' AND ANY + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL Freescale Semiconductor BE LIABLE FOR ANY + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND + * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/include/ "fsl/p1023si-pre.dtsi"
+
+/ {
+       model = "fsl,P1023";
+       compatible = "fsl,P1023RDB";
+       #address-cells = <2>;
+       #size-cells = <2>;
+       interrupt-parent = <&mpic>;
+
+       memory {
+               device_type = "memory";
+       };
+
+       soc: soc@ff600000 {
+               ranges = <0x0 0x0 0xff600000 0x200000>;
+
+               i2c@3000 {
+                       eeprom@53 {
+                               compatible = "at24,24c04";
+                               reg = <0x53>;
+                       };
+
+                       rtc@6f {
+                               compatible = "microchip,mcp7941x";
+                               reg = <0x6f>;
+                       };
+               };
+
+               usb@22000 {
+                       dr_mode = "host";
+                       phy_type = "ulpi";
+               };
+       };
+
+       lbc: localbus@ff605000 {
+               reg = <0 0xff605000 0 0x1000>;
+
+               /* NOR, NAND Flashes */
+               ranges = <0x0 0x0 0x0 0xec000000 0x04000000
+                         0x1 0x0 0x0 0xffa00000 0x08000000>;

Is there no FPGA attached to eLBC?

+               nor@0,0 {
+                       #address-cells = <1>;
+                       #size-cells = <1>;
+                       compatible = "cfi-flash";
+                       reg = <0x0 0x0 0x04000000>;
+                       bank-width = <2>;
+                       device-width = <1>;
+
+                       partition@0 {
+ /* 48MB for JFFS2 based Root file System */
+                               reg = <0x00000000 0x03000000>;
+                               label = "NOR JFFS2 Root File System";
+                       };

Don't specify JFFS2.

+                       partition@1000000 {
+ /* 32MB for Compressed Root file System Image */
+                               reg = <0x01000000 0x02000000>;
+                               label = "NAND Compressed RFS Image";
+                       };
+
+                       partition@3000000 {
+ /* 64MB for JFFS2 based Root file System */
+                               reg = <0x03000000 0x04000000>;
+                               label = "NAND JFFS2 Root File System";
+                       };
+
+                       partition@7000000 {
+                               /* 16MB for User Writable Area */
+                               reg = <0x07000000 0x01000000>;
+                               label = "NAND Writable User area";
+                       };

Don't specify JFFS2. Is there a good reason to have three separate partitions here?

diff --git a/arch/powerpc/configs/85xx/p1023_defconfig b/arch/powerpc/configs/85xx/p1023_defconfig
new file mode 100644
index 0000000..ac29fb8
--- /dev/null
+++ b/arch/powerpc/configs/85xx/p1023_defconfig
@@ -0,0 +1,183 @@
+CONFIG_PPC_85xx=y
+CONFIG_SMP=y
+CONFIG_NR_CPUS=2
+CONFIG_EXPERIMENTAL=y

CONFIG_EXPERIMENTAL doesn't exist anymore. Please only use "make savedefconfig" output, not the direct results of hand-editing an old config file.

Also please pass -M -C to git format-patch.

diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig
index efdd37c..d6424e9 100644
--- a/arch/powerpc/platforms/85xx/Kconfig
+++ b/arch/powerpc/platforms/85xx/Kconfig
@@ -112,10 +112,10 @@ config P1022_RDK
          reference board.

 config P1023_RDS
-       bool "Freescale P1023 RDS"
+       bool "Freescale P1023 RDS (P1023 RDB)"

bool "Freescale P1024 RDS/RDB"

        select DEFAULT_UIMAGE
        help
-         This option enables support for the P1023 RDS board
+ This option enables support for the P1023 RDS (P1023 RDB) board

"for the P1023 RDS and RDB boards"

-Scott
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to