Hi Scott, > -----Original Message----- > From: Wood Scott-B07421 > Sent: Saturday, September 28, 2013 1:04 AM > To: Xie Xiaobo-R63061 > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; Johnston Michael- > R49610 > Subject: Re: [PATCH V4 3/3] powerpc/85xx: Add TWR-P1025 board support > > On Wed, 2013-09-25 at 04:50 -0500, Xie Xiaobo-R63061 wrote: > > > > +#if defined(CONFIG_SERIAL_QE) > > > > + /* On P1025TWR board, the UCC7 acted as UART > > > > port. > > > > + * However, The UCC7's CTS pin is low level in > default, > > > > + * it will impact the transmission in full > > > > duplex > > > > + * communication. So disable the Flow control > > > > pin > PA18. > > > > + * The UCC7 UART just can use RXD and TXD pins. > > > > + */ > > > > + par_io_config_pin(0, 18, 0, 0, 0, 0); #endif > > > > > > Any reason not to do this unconditionally? > > > > This is a board issue, the code already have a condition - defined > > SERIAL_QE, and I will add a condition "if (machine_is(twr_p1025))". > > My point was, is there any harm in doing this without regard to > CONFIG_SERIAL_QE?
The CTS pin will be the pin of profibus if add a profibus expansion board in TWR system. If disable the pin unconditionally, it will affect the function of profibus. -Xie Xiaobo > > -Scott > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
