> > @@ -883,14 +883,19 @@ static int ldo_regulator_register(struct
> snd_soc_codec *codec,
> > struct regulator_init_data *init_data,
> > int voltage)
> > {
> > +#ifdef CONFIG_SND_SOC_FSL_SGTL5000
> > + return 0;
> > +#else
> > dev_err(codec->dev, "this setup needs regulator support in the
> kernel\n");
> > return -EINVAL;
> > +#endif
> > }
>
> If these systems don't actually need the internal regulator then should
> they not be trying to enable it?
>
Yes, I think do not trying to enable the regulator is much better.
>Alternatively if it's OK to ignore this then why is this conditional in the
>board?
>
The CONFIG_SND_SOC_FSL_SGTL5000 micro maybe confuse you and others.
And it should be CONFIG_SND_SOC_FSL_SGTL5000_VF610....
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
