On Wed, 2013-11-20 at 17:36 +0800, Gavin Shan wrote: > While we detect frozen PE on PHB3, it's always meaningful to have > the dumped diag-data for further diagnosis and analysis.
Don't we trip that during PCI probing ? For example if we probe behind a PCI-X bridge (which can exist on an adapter) we'll trip EEH on every non-existing device won't we ? Cheers, Ben. > Signed-off-by: Gavin Shan <[email protected]> > --- > arch/powerpc/platforms/powernv/eeh-ioda.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/powerpc/platforms/powernv/eeh-ioda.c > b/arch/powerpc/platforms/powernv/eeh-ioda.c > index 02245ce..481528d 100644 > --- a/arch/powerpc/platforms/powernv/eeh-ioda.c > +++ b/arch/powerpc/platforms/powernv/eeh-ioda.c > @@ -994,8 +994,11 @@ static int ioda_eeh_next_error(struct eeh_pe **pe) > if (ioda_eeh_get_pe(hose, frozen_pe_no, pe)) > break; > > + /* It would be always indicative to have PHB diag-data > */ > pr_err("EEH: Frozen PE#%x on PHB#%x detected\n", > (*pe)->addr, (*pe)->phb->global_number); > + ioda_eeh_phb_diag(hose); > + > ret = 1; > goto out; > } _______________________________________________ Linuxppc-dev mailing list [email protected] https://lists.ozlabs.org/listinfo/linuxppc-dev
