> -----Original Message----- > From: Wood Scott-B07421 > Sent: Thursday, April 17, 2014 3:36 AM > To: Wang Dongsheng-B40534 > Cc: Jin Zhengxiong-R64188; haoke...@gmail.com; Kushwaha Prabhakar-B32579; > linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH v2 1/2] fsl/corenet_generic: add a particular > initialization > for platform > > On Tue, 2014-04-15 at 21:58 -0500, Wang Dongsheng-B40534 wrote: > > > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Wednesday, April 16, 2014 3:39 AM > > > To: Wang Dongsheng-B40534 > > > Cc: Jin Zhengxiong-R64188; haoke...@gmail.com; Kushwaha > > > Prabhakar-B32579; linuxppc-dev@lists.ozlabs.org > > > Subject: Re: [PATCH v2 1/2] fsl/corenet_generic: add a particular > > > initialization for platform > > > > > > On Tue, 2014-04-15 at 13:53 +0800, Dongsheng Wang wrote: > > > > From: Wang Dongsheng <dongsheng.w...@freescale.com> > > > > > > > > Corenet_generic is a generic platform initialization. Those based > > > > on the corenet_generic board maybe need a particular initialize to > > > > enable/set some IP-Blocks. So add "Fix Generic Initialization" to > > > > solve this kind of special cases. > > > > > > I still don't understand what you mean by "fix". What are you > > > fixing, or what is fixed? > > > > > > There is no need for adding an infrastructure layer here. Just add > > > a new piece of code for t104x diu, and have it be called by an > > > appropriate initfunc. > > > > > > > "fix" is means to handle some boards those based on corenet_generic > > config file, But those boards may need some special handle. Perhaps > > these used to handle special feature codes not have an appropriate > > initfunc we cannot *just find* an appropriate place, > > I'm not asking you to "just find" anything. I'm asking you to add an initfunc > in a standalone file. > > > if more and more boards need to do this, at that time maybe *initfunc* > > looks very complicated. > > They would each have their own initfunc. There is no reason to tie this in > with > anything else. >
Sorry, if those platforms are using corenet_generic, I don’t see any standalone file for initfunc of platform. That's why I'm adding "fix" layer. BTW, if I missed something about "corenet_generic standalone file" please let me know. > > > > --- a/arch/powerpc/platforms/85xx/Kconfig > > > > +++ b/arch/powerpc/platforms/85xx/Kconfig > > > > @@ -269,6 +269,17 @@ config CORENET_GENERIC > > > > The following boards are supported for both 32bit and 64bit > kernel: > > > > P5020 DS and P5040 DS > > > > > > > > +config FIX_GENERIC_PLATFORM_INIT > > > > + bool "Fix Generic Initialization" > > > > + depends on CORENET_GENERIC > > > > > > Why does this depend on CORENET_GENERIC? > > > > > > > Because CORENET_GENERIC is a multiboards file, This is designed to handle > > this > situation. > > This DIU code is going to be just as applicable to a custom T104x board which > may or may not use CORENET_GENERIC. > "fix" is a middle layer, it's not only for T104xrdb-DIU. > > > > + default y > > > > > > No. > > > > > > > Why not? This will not increase any redundant operations if there is not any > boards need fix. > > You can see my fix.c code. > > default y should not be used for hardware specific code. > fix.c and hardware no relationship at all. :), It's just a software layer. Regards, -Dongsheng > -Scott > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
