On Mon, Apr 28, 2014 at 05:05:08PM -0700, Ram Pai wrote: > powerpc: crtsaveres.o needed only when -Os flag is enabled > > Currently on powerpc arch, out-of-tree module fails to build without > crtsaveres.o, even when the module has no dependency on the symbols > provided by the file; when built without the -Os flag. > > BTW: '-Os' flag is enabled when CONFIG_CC_OPTIMIZE_FOR_SIZE is > configured. > > This patch fixes that problem. > > Signed-off-by: Ram Pai <linux...@us.ibm.com> > > diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile > index 4c0cedf..cf12f38 100644 > --- a/arch/powerpc/Makefile > +++ b/arch/powerpc/Makefile > @@ -157,7 +157,10 @@ CPP = $(CC) -E $(KBUILD_CFLAGS) > > CHECKFLAGS += -m$(CONFIG_WORD_SIZE) -D__powerpc__ > -D__powerpc$(CONFIG_WORD_SIZE)__ > > +ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE > KBUILD_LDFLAGS_MODULE += arch/powerpc/lib/crtsavres.o > +endif > + > > # No AltiVec or VSX instructions when building kernel > KBUILD_CFLAGS += $(call cc-option,-mno-altivec)
I didn't try building a kernel or in-tree modules, but I confirmed that it allows building of out-of-tree modules when crtsavres.o is not present (e.g. as for a distro install where the kernel headers are provided by package, rather than being manually prepared from the sources). Tested-by: Brian W Hart <ha...@linux.vnet.ibm.com> _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev