On 06/05/2014 08:51 PM, Shreyas B. Prabhu wrote: > Build throws following errors when CONFIG_SMP=n > arch/powerpc/platforms/powernv/setup.c: In function > ‘pnv_kexec_wait_secondaries_down’: > arch/powerpc/platforms/powernv/setup.c:179:4: error: implicit declaration of > function ‘get_hard_smp_processor_id’ > rc = opal_query_cpu_status(get_hard_smp_processor_id(i), > > The usage of get_hard_smp_processor_id() needs the declaration from > <asm/smp.h>. The file setup.c includes <linux/sched.h>, which in-turn > includes <linux/smp.h>. However, <linux/smp.h> includes <asm/smp.h> > only on SMP configs and hence UP builds fail. > > Fix this by directly including <asm/smp.h> in setup.c unconditionally.
Can you please clean up the description in the commit message ? and also the first line in the commit message should mention that the patch is trying to fix a UP specific build failure. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
