On Mon, 27 Apr 2015 13:32:31 +0530 Nikunj A Dadhania <nik...@linux.vnet.ibm.com> wrote:
> Signed-off-by: Nikunj A Dadhania <nik...@linux.vnet.ibm.com> > --- > slof/fs/translate.fs | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/slof/fs/translate.fs b/slof/fs/translate.fs > index e2633e5..9654f24 100644 > --- a/slof/fs/translate.fs > +++ b/slof/fs/translate.fs > @@ -33,11 +33,9 @@ > dup l@ FF AND 0<> ( prop_type address data cfgspace_offset? ) > 3 pick 0= ( prop_type address data cfgspace_offset? reg_prop? ) > AND NOT IF > - 2dup 8 + ( prop_type address data address data' ) > - 2dup l@ 2 pick 8 + l@ + <= -rot l@ >= and IF > + 2dup 4 + ( prop_type address data address data' ) > + 2dup @ 2 pick 8 + @ + <= -rot @ >= and IF > l@ 03000000 and 18 rshift nip > - \ no 64bit translations supported pretend it is 32bit > - dup 3 = IF 1- THEN > ( prop_type type ) > swap drop ( type ) > UNLOOP EXIT Phew, translate-address stuff ... one of my "favorites" ;-) I wonder whether this will break "legacy" code like board-js2x ... there might have been a reason for this "pretend it is 32bit" hack (I've put Adrian Reber on CC:, maybe he still remembers why this was needed). Anyway, I think we can fix that up as soon as somebody tries to run the js2x code again (I still have a YDL PowerStation at home somewhere, maybe I will have enough spare time to reactivate it one day). And since your changes itself looks fine to me: Reviewed-by: Thomas Huth <th...@redhat.com> _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
