On 05/30/2015 11:59 AM, Alexey Kardashevskiy wrote: > On 05/29/2015 11:30 PM, Dinar valeev wrote: >> From: Dinar Valeev <dval...@suse.com> >> >> Original issue is home and end keys are not functional in grub2. > > "home" works for in grub/ubuntu14 and grub2/fedora21. "end" does not but I am > not sure that your patch will fix it, It is easy to test :)
Not sure about 'home'. It's behaviour was acting as ESC in grub menu edit. My intention was to fix 'end' sequence, so the rest was just adjusted. > >> Later I've found other inconsistencies in f1-f12 keys. > > The keys did not work in VGA or in stdio too? In my understanding this happens only on VGA. > > By "stdio" I mean running QEMU like this: > -nographic -vga none -nodefaults \ > -chardev stdio,id=id0,signal=off,mux=on \ > -device spapr-vty,id=id1,chardev=id0,reg=0x71000100 \ > -mon id=id2,chardev=id0,mode=readline > > This is how I tried grub and keys, terminal type is "xterm". What do I miss? -vga std -vnc :1 > >> "Correct sequence" was crabbed by pressing key on cat running in >> xterm. > > And the existing codes are for what type of term I have no idea what previous sequence was based on. > > >> Tested with Home, End, F2, Del and F10 keys in grub2 > > Please add "slof" in the subject so everybody could know what this is about; > and module/file name to tell what part it is touching. I did not notice the > patch till I saw it on google+ ;) Like: Next time I will, thanks for information. It would be cool to have an information for contributors, describing a procedure. > > [PATCH slof] usb-hid: Fix function keys sequence on USB > > Or/and put me or Nikunj in cc: > > >> Signed-off-by: Dinar Valeev <dval...@suse.com> >> --- >> lib/libusb/usb-hid.c | 40 +++++++++++++++++----------------------- >> 1 file changed, 17 insertions(+), 23 deletions(-) >> >> diff --git a/lib/libusb/usb-hid.c b/lib/libusb/usb-hid.c >> index f0cab8a..ccd5ba9 100644 >> --- a/lib/libusb/usb-hid.c >> +++ b/lib/libusb/usb-hid.c >> @@ -190,33 +190,29 @@ static void check_key_code(uint8_t *buf) >> case 0x3a: /* F1 */ >> write_key(0x1b); >> write_key(0x5b); >> - write_key(0x31); >> - write_key(0x31); >> - write_key(0x7e); >> + write_key(0x4f); >> + write_key(0x50); >> break; >> >> case 0x3b: /* F2 */ >> write_key(0x1b); >> write_key(0x5b); >> - write_key(0x31); >> - write_key(0x32); >> - write_key(0x7e); >> + write_key(0x4f); >> + write_key(0x51); >> break; >> >> case 0x3c: >> write_key(0x1b); /* F3 */ >> write_key(0x5b); >> - write_key(0x31); >> - write_key(0x33); >> - write_key(0x7e); >> + write_key(0x4f); >> + write_key(0x52); >> break; >> >> case 0x3d: >> write_key(0x1b); /* F4 */ >> write_key(0x5b); >> - write_key(0x31); >> - write_key(0x34); >> - write_key(0x7e); >> + write_key(0x4f); >> + write_key(0x53); >> break; >> >> case 0x3e: >> @@ -254,7 +250,7 @@ static void check_key_code(uint8_t *buf) >> case 0x42: >> write_key(0x1b); /* F9 */ >> write_key(0x5b); >> - write_key(0x31); >> + write_key(0x32); >> write_key(0x30); >> write_key(0x7e); >> break; >> @@ -262,7 +258,7 @@ static void check_key_code(uint8_t *buf) >> case 0x43: >> write_key(0x1b); /* F10 */ >> write_key(0x5b); >> - write_key(0x31); >> + write_key(0x32); >> write_key(0x31); >> write_key(0x7e); >> break; >> @@ -270,7 +266,7 @@ static void check_key_code(uint8_t *buf) >> case 0x44: >> write_key(0x1b); /* F11 */ >> write_key(0x5b); >> - write_key(0x31); >> + write_key(0x32); >> write_key(0x33); >> write_key(0x7e); >> break; >> @@ -278,7 +274,7 @@ static void check_key_code(uint8_t *buf) >> case 0x45: >> write_key(0x1b); /* F12 */ >> write_key(0x5b); >> - write_key(0x31); >> + write_key(0x32); >> write_key(0x34); >> write_key(0x7e); >> break; >> @@ -290,36 +286,34 @@ static void check_key_code(uint8_t *buf) >> case 0x49: >> write_key(0x1b); /* INS */ >> write_key(0x5b); >> - write_key(0x31); >> + write_key(0x32); >> write_key(0x7e); >> break; >> >> case 0x4a: >> write_key(0x1b); /* HOME */ >> write_key(0x5b); >> - write_key(0x32); >> - write_key(0x7e); >> + write_key(0x48); >> break; >> >> case 0x4b: >> write_key(0x1b); /* PgUp */ >> write_key(0x5b); >> - write_key(0x33); >> + write_key(0x35); >> write_key(0x7e); >> break; >> >> case 0x4c: >> write_key(0x1b); /* DEL */ >> write_key(0x5b); >> - write_key(0x34); >> + write_key(0x33); >> write_key(0x7e); >> break; >> >> case 0x4d: >> write_key(0x1b); /* END */ >> write_key(0x5b); >> - write_key(0x35); >> - write_key(0x7e); >> + write_key(0x46); >> break; >> >> case 0x4e: >> > > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
