On Wed, 2015-06-24 at 22:35 +0300, igal.liber...@freescale.com wrote: > --- /dev/null > +++ b/drivers/net/ethernet/freescale/fman/fm_drv.c
> +u16 fm_get_max_frm(void) > +{ > + return fsl_fm_max_frm; > +} > +EXPORT_SYMBOL(fm_get_max_frm); Which module is using this export? (And what does this function actually do?) > +int fm_get_rx_extra_headroom(void) > +{ > + return ALIGN(fsl_fm_rx_extra_headroom, 16); > +} > +EXPORT_SYMBOL(fm_get_rx_extra_headroom); This exports an unused function. I don't know how to, well, review a series that adds almost 20K lines. So I decided to pick one subject: exports. I think I had something to comment on all eight of them. I'm not sure if I'll try another scan with a different subject. Thanks, Paul Bolle _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev