On 07/27/2015 10:45 AM, Michael Ellerman wrote:
> On Tue, 2015-30-06 at 08:20:29 UTC, Anshuman Khandual wrote:
>> > The commit 69111bac42f5ce ("powerpc: Replace __get_cpu_var uses")
>> > replaced all usage of get_cpu_var with this_cpu_ptr inside core
>> > perf event handling on powerpc. But it skipped one of them which
>> > is being replaced with this patch.
> No it replaced all uses of __get_cpu_var(), not get_cpu_var(). The difference
> is important.Hmm, I see. Was not aware about it. Daniel suggested on this and I thought it made sense. Hence proposed the change. > > get_cpu_var() disables preemption for you, so it's only safe to switch to > this_cpu_ptr() if preemption is already disabled. Is it? We dont disable preemption inside power_pmu_event_init neither inside perf_try_init_event where it gets called from, I guess the answer is NO. Will drop this patch next time around. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
