Grant Likely wrote:
On 11/1/06, Nicolas DET <[EMAIL PROTECTED]> wrote:
Grant Likely wrote:
> As part of the transition to arch/powerpc, this patch moves the mpc5200 PSC
> driver over to the OF platform bus infrastructure.
>
> This patch is not acceptable for mainline as-is because it breaks arch/ppc > support for the mpc52xx. More rework is needed to allow it to compile for
> either arch (or alternately, fork the driver)
>

It has been hard to apply on 2.6.19-rc4 but it seems to perform well.
I add to add some entries in mpc52xx_uart_match[]

Good news, thanks for the feedback. I take it you are able to use the
serial port with this driver?

Yes.


In now looks like this:
static struct of_device_id mpc52xx_uart_match[] = {
        {
                .name = "serial",
                .compatible = "mpc52xx-psc",
        },
        {
                .name = "serial",
                .compatible = "mpc52xx-serial",
        },
        {
                .name = "serial",
                .compatible = "mpc5200-psc",
        },
        {
                .name = "serial",
                .compatible = "mpc5200-serial",
        },
        {},
};

I'd rather not do this for the mainline code.  I'd rather define a
naming convention and all of us use it.  We're early enough in this
process that we can do that since there are only two major boards
(lite5200 & Efika) on track to be supported in mainline ATM.

Having 4 compatibility blocks to support 2 boards is over-engineering.  :)

Ok. Efika will have "mpc5200-serial' inside the "compatible" property.

Regards,



begin:vcard
fn:Nicolas DET ( bplan GmbH )
n:DET;Nicolas
org:bplan GmbH
adr:;;;;;;Germany
email;internet:[EMAIL PROTECTED]
title:Software Entwicklung
tel;work:+49 6171 9187 - 31
x-mozilla-html:FALSE
url:http://www.bplan-gmbh.de
version:2.1
end:vcard

_______________________________________________
Linuxppc-embedded mailing list
Linuxppc-embedded@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-embedded

Reply via email to