I'm not sure what is going on, but that patch causes me to get "eth0: tx queue full!." messages as soon as I try to use the ethernet (Same thing happened if I just tried to remove the fcc_restart from init_fcc_startup)
> -----Original Message----- > From: Stefan Nickl [mailto:Stefan.Nickl at kontron.com] > Sent: Friday, April 08, 2005 05:49 > To: Tom Rini > Cc: Rune Torgersen; linuxppc-embedded > Subject: Re: FCC Ethernet startup crash > > On Thu, 2005-04-07 at 09:36 -0700, Tom Rini wrote: > > > The patch Stefan Nickl gave to me works perfectly, and > all it does is > > > basically move the fcc_restart. > > > The kernel was still calling fcc_restart twiche per FCC > at startup (one > > > time on init_fcc_startup, and then again in fcc_open), > now it just calls > > > it twice in fcc_open. Seems to work. > > > > Would someone please post what's needed vs current'ish 2.6 > so we can get > > the proper fix up & in? :) With the Signed-off-by & all > that.. Thanks. > > I took a little longer because I was not happy with the simple > cut'n'paste version. I believe the actual problem is that > fcc_restart() > mustn't be called before netif_start_queue(). So the original version > only shortens the race period, it does not actually resolve it. > > Unfortunately I'm deprived of suitable hardware as the focus > of my work > has shifted in the last months, so I urge everyone out there > to give it > a try. > > Signed-off-by: Stefan Nickl <Stefan.Nickl at kontron.com> > > -- > Stefan Nickl > Kontron Modular Computers > >
