On Thu, 2006-04-06 at 07:05, Vitaly Bordug wrote: > > Though I doubt if new boards are accepting to ppc/ currently, it's nice to > have a patch > available. BTW, I suggest to use phy abstraction and updated fs_enet > (submitted here recently)
I'll look into that. > > Some more notes below. <snip> > > +CONFIG_INPUT=y > > This is useless for the board iirc. <snip> > > > > +CONFIG_SOUND_GAMEPORT=y > ditto. Yes, you're right. I'm not sure why I had those enabled. <snip> > > +CONFIG_USB_ARCH_HAS_HCD=y > > +CONFIG_USB_ARCH_HAS_OHCI=y > > Not sure this is required as well. I'll disable this as well. <snip> > > +#ifdef CONFIG_PQ2FADS > > +#define F2_RXCLK 13 > > +#define F2_TXCLK 14 > > +#else > > #define F2_RXCLK 15 > > #define F2_TXCLK 16 > > +#endif > > > Hmm, this should go into the board-specific header - here should exist just a > "reasonable default" (pq2ads.h in this context). > > > > /* FCC3 Clock Source Configuration. These can be redefined in the board > > specific file. > > Can only choose from CLK13-16 */ > > +#ifdef CONFIG_PQ2FADS > > +#define F3_RXCLK 15 > > +#define F3_TXCLK 16 > > +#else > > #define F3_RXCLK 13 > > #define F3_TXCLK 14 > > +#endif > > > ditto. Ok, I'll move these defines into pq2ads.h Thanks for the feedback. I'll make the changes and resubmit. -Wade Farnsworth
