Kumar Gala wrote: > > On Nov 23, 2005, at 3:11 AM, Marcelo Tosatti wrote: > >> On Wed, Nov 23, 2005 at 01:40:38PM +1100, Paul Mackerras wrote: >>> Marcelo Tosatti writes: >>> >>>> Paul, you're OK with the following definitions on asm-ppc/io.h? >>>> >>>> +/* access ports */ >>>> +#define setbits32(_addr, _v) out_be32(&(_addr), in_be32(&(_addr)) >>>> | (_v)) >>>> +#define clrbits32(_addr, _v) out_be32(&(_addr), in_be32(&(_addr)) & >>>> ~(_v)) >>>> + >>>> +#define setbits16(_addr, _v) out_be16(&(_addr), in_be16(&(_addr)) >>>> | (_v)) >>>> +#define clrbits16(_addr, _v) out_be16(&(_addr), in_be16(&(_addr)) & >>>> ~(_v)) >>> >>> I guess so... how many drivers need these things? >> >> Many. > > Shouldn't these go into some non-arch specific location? I hate making > drivers only build on a give arch. >
Hmm, what is the worth? IIRC, in_be* stuff is defined for only ppc-specific archs(ppc(64),ppc,powerpc). > - kumar > _______________________________________________ > Linuxppc-embedded mailing list > Linuxppc-embedded at ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-embedded > > -- Sincerely, Vitaly
