On Sat, Jan 14, 2006 at 01:21:58PM -0600, Olof Johansson wrote: > > + > > +static phys_addr_t immrbase = -1; > > What does immr mean? Maybe a short comment would be good.
IMHO, this is not needed because _everybody_ who is working with these chips know what IMMR means. And there cannot be _any_ confusion about it. Let's not add useless comments. We don't add comments describing what MMU, PTE, PCI and IOMMU means, do we? Any chip specific code has tons of strange abbreviations which might be puzzling for anybody who isn't familiar with this chip but are quite clear for anybody who are. -- Eugene
