Well for the 5200 Thomas should be using include/linux/fsl_devices.h If/when 4xx coverts over to platform devices we could have an equivalent include file if truly needed.
- kumar On Aug 9, 2005, at 11:58 AM, John Otken wrote: > My patch to add on-chip OHCI support to the 440EP adds > an asm/usb.h reference to 4xx/ibm440ep.c. Thomas may > also require it for his MPC5200 mods. > > I don't like small include files either. Perhaps there > is an existing file where struct usb_hcd_platform_data > can live. Any suggestions? > > John > > > Kumar Gala wrote: > >> Why are we bothering with asm-ppc/usb.h anyways? >> >> The structure defn only appears to be used once. If this is >> true, why >> not just define it in the .c file. >> >> - kumar >> >> On Aug 9, 2005, at 7:19 AM, John Otken wrote: >> >> >>> Google found it for me. It is in my "Support 440EP >>> On-Chip OHCI USB Host Controller" patch: >>> >>> http://patchwork.ozlabs.org/linuxppc/patch?id=1965 >>> >>> >>> diff -uprN a/include/asm-ppc/usb.h b/include/asm-ppc/usb.h >>> --- a/include/asm-ppc/usb.h 1969-12-31 17:00:00.000000000 -0700 >>> +++ b/include/asm-ppc/usb.h 2005-08-05 06:13:58.000000000 -0500 >>> @@ -0,0 +1,13 @@ >>> +/* >>> + * ppc/usb.h: >>> + * >>> + */ >>> +#ifndef _PPC_USB_H >>> +#define _PPC_USB_H >>> + >>> +struct usb_hcd_platform_data { >>> + int (*start) (struct platform_device *pdev); >>> + void (*stop) (struct platform_device *pdev); >>> +}; >>> + >>> +#endif /* !(_PPC_USB_H) */ >>> >>> >>> Kumar Gala wrote: >>> >>> >>>> >>>> >>>> Begin forwarded message: >>>> >>>> >>>> >>>>> From: "Thomas S." <thomas at schnuerer-online.de> >>>>> Date: August 8, 2005 4:48:03 PM CDT >>>>> To: <linux-kernel at vger.kernel.org> >>>>> Subject: [linuxppc] 2.6.12-3 header <asm/usb.h> missing ? >>>>> >>>>> >>>>> Hello, >>>>> >>>>> Im using Kernel PPC on a MPC5200 board and try to use the onChip >>>>> USB. In >>>>> file /drivers/usb/host/ohci-ppc-soc.c a file <asm/usb.h> is >>>>> included >>>>> which seems to be missing. I cant find it anywhere , any ideas ? >>>>> >>>>> Thomas >>>>> >>>>> >>>>> >>>>> >>>>> - >>>>> To unsubscribe from this list: send the line "unsubscribe linux- >>>>> kernel" >>>>> in >>>>> the body of a message to majordomo at vger.kernel.org >>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>>> Please read the FAQ at http://www.tux.org/lkml/ >>>>> >>>>> >>>>> >>>> >>>> _______________________________________________ >>>> Linuxppc-embedded mailing list >>>> Linuxppc-embedded at ozlabs.org >>>> https://ozlabs.org/mailman/listinfo/linuxppc-embedded >>>> >>>> >>> >>> >> >> >
