On Thu, Jun 23, 2005 at 11:05:22AM -0300, Marcelo Tosatti wrote: > > Hi Andrei, > > On Thu, Jun 23, 2005 at 07:38:54PM +0400, Andrei Konovalov wrote: > <snip> > > > diff --git a/arch/ppc/syslib/m8xx_setup.c b/arch/ppc/syslib/m8xx_setup.c > > --- a/arch/ppc/syslib/m8xx_setup.c > > +++ b/arch/ppc/syslib/m8xx_setup.c > > @@ -369,7 +369,7 @@ m8xx_map_io(void) > > #if defined(CONFIG_HTDMSOUND) || defined(CONFIG_RPXTOUCH) || > > defined(CONFIG_FB_RPX) > > io_block_mapping(HIOX_CSR_ADDR, HIOX_CSR_ADDR, HIOX_CSR_SIZE, _PAGE_IO); > > #endif > > -#ifdef CONFIG_FADS > > +#if defined(CONFIG_FADS) || defined(CONFIG_MPC885ADS) > > io_block_mapping(BCSR_ADDR, BCSR_ADDR, BCSR_SIZE, _PAGE_IO); > > #endif > > #ifdef CONFIG_PCI > > I suppose you also want to include CONFIG_MPC885ADS in the > io_block_mapping(IO_BASE) > here?
I think it'd be great if we _stop_ adding new io_block_mapping users, there is ioremap() for stuff like this, let's use it instead. -- Eugene
