Hi Mark, Thanks for reviewing my patch.
Mark A. Greer wrote: > > diff -Nru a/arch/ppc/platforms/radstone_ppc7d.c > b/arch/ppc/platforms/radstone_ppc7d.c > > +void __init ppc7d_setup_peripherals(void) > > > + val32 = mv64x60_read(&bh, MV64x60_PCI1_PCI_DECODE_CNTL); > > + val32 &= ~(1 << 3); > > + mv64x60_write(&bh, MV64x60_PCI1_PCI_DECODE_CNTL, val32); > > Bit 3 is already cleared by the core code. Oh ok. I'll remove it. > > + /* Setup P2P for PCI#0 */ > > + val32 = mv64x60_read(&bh, MV64x60_PCI0_P2P_CONFIG); > > + val32 &= ~(0x00ffffff); > > + val32 |= ((bh.hose_a->first_busno & 0xff) << 16); > etc. > > Do you really use the P2P bridge? Unless I missed something, I think it > remains disabled. You shouldn't need it unless you have PCI devices on > one hose directly accessing PCI devices on the other hose. The P2P > stuff seems complicated & unnecessary. It was a feature that the Radstone folk wanted to allow, although they had no application for it at the time. I can probably just remove that code for now - if they ever do want to add that support, it would be a separate patch. I'll retest with the above code removed and submit a new patch. -- James Chapman PGP key : http://www.katalix.com/~jchapman/pgpkey.txt
