On Fri, Mar 18, 2005 at 06:26:52PM -0600, Kumar Gala wrote: > > You asked me to look at doing the following. I just want to make sure > this is what we want to do (and call it). I'm a little concerned that > 'chip' is not necessary the right name in light of TSI10x and MV64x60 > being described by ppc_sys in the future.
"chip" or "chip(set)" or anything else is fine with me (I'm horrible at names). But I don't like: > +#if defined (CONFIG_85xx) || defined (CONFIG_83xx) > + if (cur_ppc_sys_spec->ppc_sys_name) > + seq_printf(m, "chip\t\t: %s\n", cur_ppc_sys_spec->ppc_sys_name); > +#endif ifdef'ing this. If the field is set, we should print it. -- Tom Rini http://gate.crashing.org/~trini/
