On Fri, May 06, 2005 at 11:54:08AM +0400, Vitaly Bordug wrote:
[snip]
> +static struct cpm2_fec_platform_data mpc82xx_fcc1_pdata = {
> + .cp_page = CPM_CR_FCC1_PAGE,
> + .cp_block = CPM_CR_FCC1_SBLOCK,
> + .clk_trx = (PC_F1RXCLK | PC_F1TXCLK),
> + .clk_route = CMX1_CLK_ROUTE,
> + .clk_mask = CMX1_CLK_MASK,
> + .mdio = PC_MDIO,
> + .mdck = PC_MDCK,
> +
> + .device_flags = FSL_CPM2_FEC_BRD_HAS_PHY_INTR,
> + .phyid = 0,
> + .interruptPHY = SIU_INT_IRQ5,
> +};
Hmm, interruptPHY here still looks somewhat odd. Why not use the same
approach as for the rest of the fields - "default" if corresponding
define wasn't defined by the board port?
Not that I like this approach, IMHO there should be _NO_ defines at
all here and board setup code must fill them, but I guess it's OK
for now, mostly because there is no board specific files for 82xx
boards yet and this makes the patch quite small.
--
Eugene
