Benjamin Herrenschmidt wrote: >On Thu, 2005-05-26 at 13:30 -0700, Mark A. Greer wrote: > > >>Benjamin Herrenschmidt wrote: >> >> >> >>>- There is _one_ important point to keep in mind, but that has always >>>been true: None of this work before MMU_init(), >>> >>> >>> >>> >>This is very true and raises a couple issues that we should fix while >>we're at it: >> >>1) There are progress calls in MMU_init which will try to access the >>uart before its possible to create a mapping to the uart's regs >>(assuming you don't make a hack to map them and that you set up >>ppc_md.progress in your platform_init routine). We should either get >>rid of those calls in MMU_init, provide an acceptable way to make >>temporary pre-MMU_init mappings, or make sure nobody sets up >>ppc_md.progress until ioremap is working (and also get rid of the calls >>in MMU_init b/c they're never used). >> >> > >Or have the implementation of progress() check if the mapping was done >or not ... >
Doesn't seem worth it to me. > In any ways, I always disliked ppc_md.progress deeply. It's >ugly and clutters the code. It has never proven very useful to me vs. >having an early console. > Okay, let's rip it out of MMU_init then. Anyone have a problem with that? Mark
