On Thu, Oct 17, 2002 at 06:34:56PM +0200, Marius Groeger wrote: > On Thu, 17 Oct 2002, Tom Rini wrote: > > > On Thu, Oct 17, 2002 at 05:18:21PM +0100, Alex Zeffertt wrote: > > > On Thu, 17 Oct 2002, Tom Rini wrote: > > > > > > > On Thu, Oct 17, 2002 at 05:02:23PM +0100, Alex Zeffertt wrote: > > > > > On Thu, 17 Oct 2002, leeyang wrote: > > > > > > > > > > Hi, > > > > > > > > > > I've written a rtc driver for the mpc860. See attached files. > > > > > > > > > > HOWTO BUILD > > > > > > > > > > 1. Edit KERNEL_DIR in Makefile > > > > > 2. make (builds rtc.o and rtc) > > > > > > > > This appears to be a binary file. And the easiest way to do this is to > > > > make ppc_md.set_rtc_time / ppc_md.get_rtc_time point to functions which > > > > do what their name implies. Then enable CONFIG_PPC_RTC > > > > > > You're right. This is actually what the module I have sent you does! > > > The reason I wrote the module was merely to provide a way for userland > > > programs to set the RTC. > > > > Er, okay. But why not just modify > > m8xx_setup.c::m8xx_get_rtc_time/m8xx_set_rtc_time to allow for the > > get/set routines there to be overriden ? Doing that would be nice and > > clean, and also allow the 'new' genrtc driver in 2.5 to just work as > > well. > > Probably a little late, but: see also drivers/macintosh/rtc.c which is > a perfectly generic rtc driver at a perfectly non-generic location. > Don't mix this up with drivers/char/rtc.c, which is the other way > round. Shudder.
Right. drivers/macintosh/rtc.c is what makes use of ppc_md.set/get_rtc_time. Thankfully in 2.5 there's now drivers/char/genrtc.c, which is generic and has replaced drivers/macintosh/rtc.c (and uses the same ppc_md hooks, when the driver is compiled on PPC). -- Tom Rini (TR1265) http://gate.crashing.org/~trini/ ** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
